tests: Run rspec tests out of bazel build output by mxinden · Pull Request #2907 · coreos/tectonic-installer

mxinden · 2018-02-07T10:41:02Z

Build tarball and smoke tests in previous Jenkins stage
Unzip the release tarball
Setup build folder and $PATH
Make rspec use release folder instead of git repository

coreosbot · 2018-02-07T10:41:04Z

Can one of the admins verify this patch?

mxinden · 2018-02-07T10:41:55Z

tests/rspec/lib/cluster_support.rb

    output += "Standard output: \n#{stdout}"
    output += "\nStandard error: \n#{stderr}"
    output += "\nEnd of journal of #{service} service on #{destination_ip}"
-    puts output


@cpanato We have the logs output as a Jenkins archive. Is the print statement to the Jenkins logs still needed?

you can remove, please.

mxinden · 2018-02-14T14:56:32Z

Jenkinsfile

              ) {
                unstash 'clean-repo'
-                unstash 'smoke-test-binary'
+                unstash 'tectonic.tar.gz'


I can combine the unstash lines here into a function and invoke that function in runRSpecTestBareMetal as well.

mxinden · 2018-02-14T14:58:13Z

tests/rspec/lib/aws_vpc.rb


  def create
-    Dir.chdir('../../contrib/internal-cluster') do
+    Dir.chdir(File.join(ENV['RSPEC_PATH'], '../../contrib/internal-cluster')) do


Instead of relying on the current dir to be the correct dir, I use absolute paths via the RSPEC_PATH and RELEASE_TARBALL_PATH. What do you think @cpanato? Should make the framework more robust for the future.

mxinden · 2018-02-14T14:59:04Z

tests/rspec/lib/smoke_test.rb

 # SmokeTest contains helper functions to operate the smoke tests written in
 # golang
 module SmokeTest
-  def self.build


Smoke test binary is build by Bazel from now on.

mxinden · 2018-02-14T14:59:48Z

tests/rspec/spec/spec_helper.rb

  config.silence_filter_announcements = true

+  # Untar release tarball
+  # TODO: Pipe tar output to /dev/null


@mxinden address TODO

mxinden · 2018-02-14T15:00:10Z

tests/rspec/spec/spec_helper.rb

+  raise 'failed to untar build tarball' unless succeeded
+
+  # Add terraform binary to path
+  ENV['PATH'] =


With the new CLI, this should not be needed anymore.

mxinden · 2018-02-14T15:01:00Z

@cpanato Would you mind giving this another review? Looking forward to your thoughts.

cpanato · 2018-02-15T10:37:30Z

Jenkinsfile

+
+                    cp bazel-bin/tectonic.tar.gz .
+                    cp bazel-bin/tests/smoke/linux_amd64_stripped/smoke .
+                    ls -la


do you need this?

cpanato · 2018-02-15T10:47:18Z

can we run on aws as well?

make a few comments. this looks great to me 😄 nice job to adapt to use bazel!

0. Build tarball and smoke tests in previous Jenkins stage 1. Unzip the release tarball 2. Setup build folder and $PATH 3. Make rspec use release folder instead of git repository

cpanato

nice work!

tests: Cherry-pick #2907

mxinden added platform/aws do-not-merge run-smoke-tests labels Feb 7, 2018

mxinden commented Feb 7, 2018

View reviewed changes

mxinden changed the title ~~tests: Run rspec tests out of bazel build output~~ [WIP] tests: Run rspec tests out of bazel build output Feb 7, 2018

mxinden force-pushed the bazel-rspec branch 15 times, most recently from ea2a18b to be148ce Compare February 9, 2018 13:43

mxinden added platform/azure platform/gcp platform/bare-metal platform/govcloud and removed platform/aws labels Feb 13, 2018

mxinden force-pushed the bazel-rspec branch 4 times, most recently from 32f764b to 99003a3 Compare February 14, 2018 09:53

mxinden force-pushed the bazel-rspec branch 2 times, most recently from c1fc083 to 7a03544 Compare February 14, 2018 12:11

mxinden commented Feb 14, 2018

View reviewed changes

cpanato reviewed Feb 15, 2018

View reviewed changes

mxinden added platform/aws and removed platform/azure platform/bare-metal platform/gcp platform/govcloud labels Feb 15, 2018

mxinden force-pushed the bazel-rspec branch from 7a03544 to 5574fb1 Compare February 15, 2018 11:42

mxinden added platform/bare-metal and removed platform/aws labels Feb 15, 2018

mxinden force-pushed the bazel-rspec branch from 5574fb1 to 0da5bad Compare February 15, 2018 16:09

mxinden added platform/azure and removed platform/bare-metal labels Feb 15, 2018

tests: Run rspec tests out of bazel build output

4cd53e5

0. Build tarball and smoke tests in previous Jenkins stage 1. Unzip the release tarball 2. Setup build folder and $PATH 3. Make rspec use release folder instead of git repository

mxinden force-pushed the bazel-rspec branch from 0da5bad to 4cd53e5 Compare February 15, 2018 17:02

cpanato approved these changes Feb 15, 2018

View reviewed changes

mxinden changed the title ~~[WIP] tests: Run rspec tests out of bazel build output~~ tests: Run rspec tests out of bazel build output Feb 15, 2018

mxinden removed the do-not-merge label Feb 16, 2018

mxinden merged commit 7ff529e into coreos:master Feb 16, 2018

mxinden added a commit that referenced this pull request Feb 16, 2018

Merge pull request #2967 from mxinden/ut2-bazel-rspec

baad1c5

tests: Cherry-pick #2907

Conversation

mxinden commented Feb 7, 2018

Uh oh!

coreosbot commented Feb 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mxinden commented Feb 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpanato commented Feb 15, 2018

Uh oh!

cpanato left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants